Add SorobanDataBuilder to prepare sorobanData easily. #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirms
reviewed
Aug 14, 2023
| * @param metadataBytes number of extended metadata bytes (uint32) | ||
| * @return this builder instance | ||
| */ | ||
| public SorobanDataBuilder setResources( |
There was a problem hiding this comment.
because all the parameters have the same type I think it could lead to mistakes where you pass in the parameters in the wrong order. Is it possible to have a Resources builder object that could be passed into setResources()?
tamirms
reviewed
Aug 14, 2023
| * sorobanData | ||
| * @return this builder instance | ||
| */ | ||
| public SorobanDataBuilder setFootprint( |
There was a problem hiding this comment.
because all the parameters have the same type I think it could lead to mistakes where you pass in the parameters in the wrong order. Is it possible to have a footprint builder object that could be passed into setFootprint()?
There was a problem hiding this comment.
If necessary, we can remove this method and only keep setReadOnly and setReadOnly?
There was a problem hiding this comment.
yes, that's an even better idea.
tamirms
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #508